-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Content] Adjust Mitre Att&ck Mappings - Windows Rules #3165
Conversation
@@ -30,7 +30,7 @@ sequence by process.entity_id with maxspan=5m | |||
process.name : ("wscript.exe", "cscript.exe", "mshta.exe", "wmic.exe", "regsvr32.exe", "svchost.exe", "dllhost.exe", "cmstp.exe")] | |||
[file where host.os.type == "windows" and event.type != "deletion" and | |||
file.name : ("wscript.exe.log", | |||
"cscript.exe", | |||
"cscript.exe.log", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My man even doing some tunings along the way
rules/windows/collection_email_powershell_exchange_mailbox.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! That MITRE map is going to look amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a lot of great work. Most of my comments are for adding an additional tag for the new Tactic for some rules
rules_building_block/lateral_movement_unusual_process_sql_accounts.toml
Outdated
Show resolved
Hide resolved
@imays11, can you add those tags to the rules in this branch(mitre_mapping_review)? I don't think this is enforced though, I think we may be fine with the primary tag only |
Yea I don't think it's enforced either but a good practice especially if we're taking the time to add new tactics to improve mapping we should keep the tags updated too. I'll add the additional tags! |
updated tags and fixed branch conflicts
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> Removed changes from: - rules/windows/credential_access_dcsync_newterm_subjectuser.toml - rules/windows/credential_access_lsass_openprocess_api.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/defense_evasion_execution_msbuild_started_by_script.toml - rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_unsigned_dll_loaded_from_suspdir.toml - rules/windows/persistence_driver_newterm_imphash.toml - rules/windows/persistence_service_dll_unsigned.toml - rules_building_block/execution_unsigned_service_executable.toml (selectively cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> Removed changes from: - rules/windows/credential_access_lsass_openprocess_api.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/defense_evasion_execution_msbuild_started_by_script.toml - rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/persistence_driver_newterm_imphash.toml - rules_building_block/execution_unsigned_service_executable.toml (selectively cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> Removed changes from: - rules/windows/credential_access_lsass_openprocess_api.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/defense_evasion_execution_msbuild_started_by_script.toml - rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/persistence_driver_newterm_imphash.toml - rules_building_block/execution_unsigned_service_executable.toml (selectively cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> Removed changes from: - rules/windows/credential_access_lsass_openprocess_api.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml (selectively cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> Removed changes from: - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml (selectively cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> (cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> (cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> (cherry picked from commit f584fb6)
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules * Fix dates * Fix unit test errors * updated tags and fixed branch conflicts updated tags and fixed branch conflicts * description nit * Reverting unintended changes * Update initial_access_suspicious_ms_office_child_process.toml --------- Co-authored-by: imays11 <[email protected]> (cherry picked from commit f584fb6)
Issues
Resolves #3098
Summary
Improve the Mitre Mappings for the Windows Ruleset