Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Content] Adjust Mitre Att&ck Mappings - Windows Rules #3165

Merged
merged 11 commits into from
Oct 15, 2023

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Oct 9, 2023

Issues

Resolves #3098

Summary

Improve the Mitre Mappings for the Windows Ruleset

@@ -30,7 +30,7 @@ sequence by process.entity_id with maxspan=5m
process.name : ("wscript.exe", "cscript.exe", "mshta.exe", "wmic.exe", "regsvr32.exe", "svchost.exe", "dllhost.exe", "cmstp.exe")]
[file where host.os.type == "windows" and event.type != "deletion" and
file.name : ("wscript.exe.log",
"cscript.exe",
"cscript.exe.log",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My man even doing some tunings along the way

@w0rk3r w0rk3r requested a review from Aegrah October 9, 2023 20:37
Copy link
Contributor

@Aegrah Aegrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! That MITRE map is going to look amazing!

Copy link
Contributor

@imays11 imays11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of great work. Most of my comments are for adding an additional tag for the new Tactic for some rules

@w0rk3r
Copy link
Contributor Author

w0rk3r commented Oct 11, 2023

@imays11, can you add those tags to the rules in this branch(mitre_mapping_review)? I don't think this is enforced though, I think we may be fine with the primary tag only

@imays11
Copy link
Contributor

imays11 commented Oct 13, 2023

@imays11, can you add those tags to the rules in this branch(mitre_mapping_review)? I don't think this is enforced though, I think we may be fine with the primary tag only

Yea I don't think it's enforced either but a good practice especially if we're taking the time to add new tactics to improve mapping we should keep the tags updated too. I'll add the additional tags!

@w0rk3r w0rk3r merged commit f584fb6 into main Oct 15, 2023
11 checks passed
@w0rk3r w0rk3r deleted the mitre_mapping_review branch October 15, 2023 21:12
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

Removed changes from:
- rules/windows/credential_access_dcsync_newterm_subjectuser.toml
- rules/windows/credential_access_lsass_openprocess_api.toml
- rules/windows/credential_access_suspicious_lsass_access_memdump.toml
- rules/windows/defense_evasion_execution_msbuild_started_by_script.toml
- rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml
- rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml
- rules/windows/defense_evasion_unsigned_dll_loaded_from_suspdir.toml
- rules/windows/persistence_driver_newterm_imphash.toml
- rules/windows/persistence_service_dll_unsigned.toml
- rules_building_block/execution_unsigned_service_executable.toml

(selectively cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

Removed changes from:
- rules/windows/credential_access_lsass_openprocess_api.toml
- rules/windows/credential_access_suspicious_lsass_access_memdump.toml
- rules/windows/defense_evasion_execution_msbuild_started_by_script.toml
- rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml
- rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml
- rules/windows/persistence_driver_newterm_imphash.toml
- rules_building_block/execution_unsigned_service_executable.toml

(selectively cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

Removed changes from:
- rules/windows/credential_access_lsass_openprocess_api.toml
- rules/windows/credential_access_suspicious_lsass_access_memdump.toml
- rules/windows/defense_evasion_execution_msbuild_started_by_script.toml
- rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml
- rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml
- rules/windows/persistence_driver_newterm_imphash.toml
- rules_building_block/execution_unsigned_service_executable.toml

(selectively cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

Removed changes from:
- rules/windows/credential_access_lsass_openprocess_api.toml
- rules/windows/credential_access_suspicious_lsass_access_memdump.toml
- rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml

(selectively cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

Removed changes from:
- rules/windows/credential_access_suspicious_lsass_access_memdump.toml
- rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml

(selectively cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

(cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

(cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

(cherry picked from commit f584fb6)
protectionsmachine pushed a commit that referenced this pull request Oct 15, 2023
* [Security Content] Adjust Mitre Att&ck Mappings - Windows Rules

* Fix dates

* Fix unit test errors

* updated tags and fixed branch conflicts

updated tags and fixed branch conflicts

* description nit

* Reverting unintended changes

* Update initial_access_suspicious_ms_office_child_process.toml

---------

Co-authored-by: imays11 <[email protected]>

(cherry picked from commit f584fb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] Review Detection Rules for Mitre Mapping Coverage Improvements
4 participants