-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Version bump with previous #1870
Merged
brokensound77
merged 6 commits into
elastic:main
from
brokensound77:bug-version-bump-with-previous
Mar 24, 2022
Merged
[Bug] Version bump with previous #1870
brokensound77
merged 6 commits into
elastic:main
from
brokensound77:bug-version-bump-with-previous
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
commented
Mar 23, 2022
Opened as draft - still want to test a bit more to verify assumptions |
brokensound77
changed the title
Bug version bump with previous
[Bug] Version bump with previous
Mar 24, 2022
brokensound77
commented
Mar 24, 2022
…into bug-version-bump-with-previous
Mikaayenson
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP: LGTM
terrancedejesus
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP: LGTM
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
* save changes to top level for route C; verbose prints * update top level on forked rule without overriding min_stack_version * add check to ensure previous version !> current (cherry picked from commit f4c94af)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #1868
Summary
When a forked rule has changes, also save version changes to the top level
This also reconciles the errors in the
version.lock.json