Revert "[Rule Tuning] Interactive Terminal Spawned via Python - Python3 and bypasses fix" #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
w0rk3r
approved these changes
Jan 26, 2022
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
1 task
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 26, 2022
brokensound77
added a commit
to elastic/kibana
that referenced
this pull request
Jan 27, 2022
* [Detection Rules] Add 8.0 rules * rollback changes for python tty rule elastic/detection-rules#1731
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 27, 2022
* [Detection Rules] Add 8.0 rules * rollback changes for python tty rule elastic/detection-rules#1731 (cherry picked from commit 36722fa)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Jan 27, 2022
* [Detection Rules] Add 8.0 rules * rollback changes for python tty rule elastic/detection-rules#1731 (cherry picked from commit 36722fa) Co-authored-by: Justin Ibarra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
related to #1730
Description
Rolls back changes to rule due to a bug (8.0) where existing rules change rule
type. We can explore adding these changes back in after a fix is implemented.If the change is needed urgently before that, we can deprecate this rule and create a new one with the changes