[Bug] Fix ML job IDs that used hyphens #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajosh0504
reviewed
Jun 15, 2021
ajosh0504
approved these changes
Jun 15, 2021
spong
approved these changes
Jun 15, 2021
bm11100
reviewed
Jun 15, 2021
|
Should we also add the prefix “network” to their names like the others, makes them easier to find in the folder e.g. network_rare_destination_country |
|
Feel free to change the folder or add subfolders however you see fit, @randomuserid. I'll let you do that in a separate PR. |
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 15, 2021
* Fix ML job IDs that used hyphens * Update ml_high_count_network_denies.toml * Update ml_spike_in_traffic_to_a_country.toml * Set updated_date (cherry picked from commit 49cb2e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes elastic/kibana#102146 (which might transfer here)
Summary
See the ticket for more info.
This PR fixes the job IDs to use
_instead of-