Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update bump version workflow to work for x.x branches #2757

Merged
merged 15 commits into from
Nov 27, 2024
Merged

[CI] Update bump version workflow to work for x.x branches #2757

merged 15 commits into from
Nov 27, 2024

Conversation

kubasobon
Copy link
Member

@kubasobon kubasobon commented Nov 21, 2024 •
edited
Loading

Summary of your changes

This PR aims to make "Bump Workflow" action usable for branches like 8.x.
It also introduces a "Synchronize Cloudbeat Versions on release" workflow, which solves version drift in bin/hermit.hcl file.

Work in progress. Testing pending

Related Issues

Closes #2492
Closes #2563

@kubasobon kubasobon self-assigned this Nov 21, 2024
@mergify Mergify
Copy link

mergify bot commented Nov 21, 2024

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@kubasobon kubasobon mentioned this pull request Nov 21, 2024
Closed
@kubasobon kubasobon marked this pull request as ready for review November 25, 2024 12:06
@kubasobon kubasobon requested a review from a team as a code owner November 25, 2024 12:06
gurevichdmitry
gurevichdmitry reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It would be helpful to provide some workflow runs to ensure that the functionality is working as expected.

@kubasobon kubasobon force-pushed the improve-bump-version-ci branch from ebed427 to 8b112c0 Compare November 26, 2024 14:14
@kubasobon
Copy link
Member Author

Test PRs created by test run:

gurevichdmitry
gurevichdmitry approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubasobon LGTM

@kubasobon kubasobon enabled auto-merge (squash) November 27, 2024 10:22
@kubasobon kubasobon merged commit d175d52 into elastic:main Nov 27, 2024
11 checks passed
@kubasobon kubasobon deleted the improve-bump-version-ci branch November 27, 2024 10:39
mergify bot pushed a commit that referenced this pull request Nov 27, 2024
@kubasobon @mergify
[CI] Update bump version workflow to work for x.x branches (#2757)
b113ad4 
(cherry picked from commit d175d52)
@mergify mergify bot mentioned this pull request Nov 27, 2024
Merged
kubasobon added a commit that referenced this pull request Dec 3, 2024
@mergify @kubasobon
[8.x](backport #2757) [CI] Update bump version workflow to work for x…
6b4f392 
….x branches (#2783)

[CI] Update bump version workflow to work for x.x branches (#2757)

(cherry picked from commit d175d52)

Co-authored-by: Kuba Soboń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurevichdmitry gurevichdmitry gurevichdmitry approved these changes

Assignees

@kubasobon kubasobon

Labels
backport-v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump hermit.hcl version whenever version.go is bumped Workflows updates after 8.x branch-out
2 participants
@kubasobon @gurevichdmitry