[Asset Inventory][AWS] Add integration test cases for implemented assets #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
This reverts commit 117a0fe.
…o assetinv-aws-cases
|
Successful Tests workflow run https://github.com/elastic/cloudbeat/actions/runs/10791535134/job/29929279587 |
oren-zohar
reviewed
Sep 10, 2024
Comment on lines
8
to
12
| # =============================================================== | ||
| # The commented-out test cases work, but the resources are not | ||
| # present in the test account yet. You can uncomment them, | ||
| # provided you create matching resources in test AWS account. | ||
| # =============================================================== |
There was a problem hiding this comment.
then let's create them?
|
Update Created and uncommented all resources. 22/22 passing. |
oren-zohar
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
This PR adds
12 enabled and 8 disabled22 test cases for AWS Asset Inventory.Screenshot/Data
In the comments
Related Issues
Extra test cases for https://github.com/elastic/security-team/issues/10322
Checklist
I have added the necessary README/documentation (if appropriate)