Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #2347) Fix Azure ARM Template: missing resources #2351

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 23, 2024

Summary of your changes

By setting resourceGroup to role assignment, the role assignment has a specific (reduced) scope for the specified resource group.

Role assignment with resourceGroup (scope to this specific resource group):

{
    "properties": {
        "roleDefinitionId": "/subscriptions/<sub id>/providers/Microsoft.Authorization/roleDefinitions/<definition id>",
        "principalId": "<pid>",
        "principalType": "ServicePrincipal",
        "scope": "/subscriptions/<sub id>/resourcegroups/evgb-815bclong"
    },
    "id": "/subscriptions/<sub id>/resourcegroups/evgb-815bclong/providers/Microsoft.Authorization/roleAssignments/<id>",
    "type": "Microsoft.Authorization/roleAssignments",
    "name": "<id>"
}

Role assignment without resourceGroup (scope to the subscription):

{
    "properties": {
        "roleDefinitionId": "/subscriptions/<sub id>/providers/Microsoft.Authorization/roleDefinitions/<definition id>",
        "principalId": "<pid>",
        "principalType": "ServicePrincipal",
        "scope": "/subscriptions/<sub id>"
    },
    "id": "/subscriptions/<sub id>/providers/Microsoft.Authorization/roleAssignments/<id>",
    "type": "Microsoft.Authorization/roleAssignments",
    "name": "<id>"
}

Screenshot/Data

Related Issues

Fixes: #2346

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?


This is an automatic backport of pull request #2347 done by [Mergify](https://mergify.com).

* Fix Azure ARM Template: missing resources

* fix dev

* lint fix

* revert and skip linter

(cherry picked from commit a6eca90)
@mergify mergify bot requested a review from a team as a code owner July 23, 2024 12:55
@mergify mergify bot added the backport label Jul 23, 2024
Copy link

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@moukoublen moukoublen merged commit b4d79a3 into 8.15 Jul 23, 2024
26 checks passed
@moukoublen moukoublen deleted the mergify/bp/8.15/pr-2347 branch July 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants