Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: Fetch bastions #1385

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

orestisfl
Copy link
Contributor

@orestisfl orestisfl commented Oct 3, 2023

Summary of your changes

Done by re-purposing the AzureActivityLogAlertsFetcher into a AzureBatchAssetFetcher which fetches all resources that need to be batched.

Relevant for rule:
7.1 Ensure an Azure Bastion Host Exists (Automated)

Ensure there is at least one Bastion host listed under the Name column

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Done by re-purposing the `AzureActivityLogAlertsFetcher` into a
`AzureBatchAssetFetcher` which fetches all resources that need to be
batched.

Relevant for rule:
7.1 Ensure an Azure Bastion Host Exists (Automated)
> Ensure there is at least one Bastion host listed under the Name column
@orestisfl orestisfl requested a review from jeniawhite October 3, 2023 12:30
@orestisfl orestisfl requested a review from a team as a code owner October 3, 2023 12:30
@orestisfl orestisfl self-assigned this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

Copy link
Contributor

@jeniawhite jeniawhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure that we will refactor when we will have multiple subscriptions and management groups.
Since these batches are subscription scoped.

@orestisfl orestisfl merged commit 8fa190c into elastic:main Oct 3, 2023
@orestisfl orestisfl deleted the azure-bastion-batch-fetcher branch October 3, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CIS Azure] Virtual Machines rules
2 participants