Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Add websites asset type #1376

Merged
merged 4 commits into from
Oct 2, 2023
Merged

[Azure] Add websites asset type #1376

merged 4 commits into from
Oct 2, 2023

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Oct 2, 2023

adds a new asset type to be fetched for evaluation, goes with elastic/csp-security-policies#316

@orouz orouz added the CIS Azure label Oct 2, 2023
@orouz orouz requested a review from a team as a code owner October 2, 2023 07:26
@mergify mergify bot assigned orouz Oct 2, 2023
@mergify
Copy link

mergify bot commented Oct 2, 2023

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

❌ No tests were run ❌

@@ -42,6 +42,7 @@ type AzureResource struct {
var AzureResourceTypes = map[string]string{
inventory.VirtualMachineAssetType: fetching.AzureVMType,
inventory.StorageAccountAssetType: fetching.AzureStorageAccountType,
inventory.WebSitesAssetType: fetching.AzureWebSiteType,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should inline all the asset type strings and generate the sub type (or type) from the string itself. same as we did in GCP

@mergify
Copy link

mergify bot commented Oct 2, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b azure_websites upstream/azure_websites
git merge upstream/main
git push upstream azure_websites

@orouz orouz enabled auto-merge (squash) October 2, 2023 11:00
@mergify
Copy link

mergify bot commented Oct 2, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b azure_websites upstream/azure_websites
git merge upstream/main
git push upstream azure_websites

@orouz orouz merged commit d9a08b5 into elastic:main Oct 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants