-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Add websites asset type #1376
Conversation
This pull request does not have a backport label. Could you fix it @orouz? 🙏
|
❌ No tests were run ❌ |
@@ -42,6 +42,7 @@ type AzureResource struct { | |||
var AzureResourceTypes = map[string]string{ | |||
inventory.VirtualMachineAssetType: fetching.AzureVMType, | |||
inventory.StorageAccountAssetType: fetching.AzureStorageAccountType, | |||
inventory.WebSitesAssetType: fetching.AzureWebSiteType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should inline all the asset type strings and generate the sub type (or type) from the string itself. same as we did in GCP
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
adds a new asset type to be fetched for evaluation, goes with elastic/csp-security-policies#316