Azure: Fetch disk type #1370
Merged
Azure: Fetch disk type #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIS Azure 7.4
5 tasks
📊 Allure Report - 💚 No failures were reported.
|
orestisfl
force-pushed
the
azure-7_4
branch
from
28adaf7 to
f3ffd3d
Compare
orestisfl
commented
Sep 29, 2023
| @@ -40,8 +40,9 @@ type AzureResource struct { | |||
| } | |||
|
|
|||
| var AzureResourceTypes = map[string]string{ | |||
| inventory.VirtualMachineAssetType: fetching.AzureVMType, | |||
| inventory.DiskAssetType: fetching.AzureDiskType, | |||
There was a problem hiding this comment.
I actually find having two constants and a map harder to read than just having a map with hardcoded strings, since the strings are only used in this map I suggest inlining these constants.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Needed for CIS Azure 7.4, see elastic/csp-security-policies#311
Related Issues
Checklist