Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS Azure] Batch Fetcher: Group resources by Subscription ID #1391

Closed
2 tasks done
orestisfl opened this issue Oct 4, 2023 · 0 comments · Fixed by #1400
Closed
2 tasks done

[CIS Azure] Batch Fetcher: Group resources by Subscription ID #1391

orestisfl opened this issue Oct 4, 2023 · 0 comments · Fixed by #1400
Assignees
@orestisfl
Labels
CIS Azure Team:Cloud Security Cloud Security team related

Comments

@orestisfl
Copy link
Contributor

orestisfl commented Oct 4, 2023 •
edited
Loading

Motivation
Currently, batch asset types like bastions are sent together regardless of their subscription ID, making the assumption that they are all from the same subscription. We need to change this.

This is necessary for organization support but might be beneficial for the single account case as well

Definition of done
What needs to be completed at the end of this task

Out of scope
Expanding support of multi-account onboarding
@orestisfl orestisfl added the Team:Cloud Security Cloud Security team related label Oct 4, 2023
orestisfl added a commit to orestisfl/cloudbeat that referenced this issue Oct 5, 2023
@orestisfl
Azure: Batch Fetcher: Group resource by subscription ID
e280f4f 
Fixes elastic#1391
@orestisfl orestisfl mentioned this issue Oct 5, 2023
Merged
2 tasks
orestisfl added a commit to orestisfl/cloudbeat that referenced this issue Oct 5, 2023
@orestisfl
Azure: Batch Fetcher: Group resource by subscription ID
eadc8bf 
Fixes elastic#1391
orestisfl added a commit that referenced this issue Oct 10, 2023
@orestisfl
Azure: Batch Fetcher: Group resources by subscription IDs and types (#…
fe0640d 
…1400)

This has the side-benefit of only requiring one query for all types.

Utilizes lo.GroupBy

Fixes #1391
@orestisfl orestisfl self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orestisfl orestisfl

Labels
CIS Azure Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Azure: Batch Fetcher: Group resources by subscription IDs and types orestisfl/cloudbeat
1 participant
@orestisfl