Refactor test checks.

Clearly check either the error case or the successful result case.
elastic · Sep 10, 2024 · 4ceec3a · 4ceec3a
1 parent 5f5f60d
commit 4ceec3a
Show file tree

Hide file tree

Showing 10 changed files with 60 additions and 50 deletions.
diff --git a/pkg/api/organizationapi/get_test.go b/pkg/api/organizationapi/get_test.go
@@ -92,11 +92,12 @@ func TestGetOrganization(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := Get(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/invitation_create_test.go b/pkg/api/organizationapi/invitation_create_test.go
@@ -139,11 +139,12 @@ func TestCreateInvitation(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := CreateInvitation(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/invitation_delete_test.go b/pkg/api/organizationapi/invitation_delete_test.go
@@ -69,11 +69,12 @@ func TestDeleteInvitation(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := DeleteInvitation(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if err == nil && !assert.NotNil(t, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.NotNil(t, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/invitation_list_test.go b/pkg/api/organizationapi/invitation_list_test.go
@@ -135,11 +135,12 @@ func TestListInvitations(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := ListInvitations(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/list_test.go b/pkg/api/organizationapi/list_test.go
@@ -97,11 +97,12 @@ func TestListOrganization(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := List(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/member_delete_test.go b/pkg/api/organizationapi/member_delete_test.go
@@ -69,11 +69,12 @@ func TestDeleteMember(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := DeleteMember(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if err == nil && !assert.NotNil(t, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.NotNil(t, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/member_list_test.go b/pkg/api/organizationapi/member_list_test.go
@@ -111,11 +111,12 @@ func TestListMembers(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := ListMembers(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/member_role_assignments_add_test.go b/pkg/api/organizationapi/member_role_assignments_add_test.go
@@ -89,11 +89,12 @@ func TestAddRoleAssignments(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := AddRoleAssignments(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if got != nil && !assert.Equal(t, test.want, *got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, *got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/member_role_assignments_remove_test.go b/pkg/api/organizationapi/member_role_assignments_remove_test.go
@@ -89,11 +89,12 @@ func TestRemoveRoleAssignments(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := RemoveRoleAssignments(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if got != nil && !assert.Equal(t, test.want, *got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, *got)
 			}
 		})
 	}

diff --git a/pkg/api/organizationapi/update_test.go b/pkg/api/organizationapi/update_test.go
@@ -117,11 +117,12 @@ func TestUpdateOrganization(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := Update(test.params)
-			if err != nil && !assert.EqualError(t, err, test.err) {
-				t.Error(err)
-			}
-			if !assert.Equal(t, test.want, got) {
-				t.Error(err)
+			if test.err != "" {
+				assert.EqualError(t, err, test.err)
+				assert.Nil(t, got)
+			} else {
+				assert.NoError(t, err)
+				assert.Equal(t, test.want, got)
 			}
 		})
 	}