-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting index field limit during stack monitoring e2e test. #8284
Allow setting index field limit during stack monitoring e2e test. #8284
Conversation
Signed-off-by: Michael Montgomery <[email protected]>
buildkite test this -f p=gke,t=Test.*StackMonitoring,s=8.16.0 |
Why are we not using the workaround described in the known issue in the beats repo?
As a conditional element in https://github.com/elastic/cloud-on-k8s/blob/main/pkg/controller/kibana/stackmon/metricbeat.tpl.yml |
I didn't consider this approach. Definitely simpler. I'll get this implemented, and ping you when done. Thanks for the pointer. |
Signed-off-by: Michael Montgomery <[email protected]>
buildkite test this -f p=gke,t=Test.*StackMonitoring,s=8.16.0 |
@pebrc This has been updated, and the e2e tests are passing for stack monitoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…astic#8284) * Allow setting index field limit during stack monitoring e2e test. * Use beats setup to handle initial index settings. --------- Signed-off-by: Michael Montgomery <[email protected]> (cherry picked from commit 7f816b6)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
) (#8288) * Allow setting index field limit during stack monitoring e2e test. * Use beats setup to handle initial index settings. --------- Signed-off-by: Michael Montgomery <[email protected]> (cherry picked from commit 7f816b6)
Related: elastic/beats#41640
Resolves: #8250
Reverts: #8251
This change allows the
TestMetricbeatStackMonitoringRecipe
test to set a custom index field limit as Metricbeat versions >= 8.16.x seem to have an index template that exceeds the default limit of 10,000 fields per index. This sets this limit on all versions of this test, and doesn't limit to >= 8.16.x, but that can be enabled if we feel it's needed. It seems harmless to set this across all versions.