Telemetry test cases support 8.10 and later Kibana versions #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite test this -f p=kind,t=TestTelemetry |
|
buildkite test this -f p=gke,t=TestTelemetry,s=8.10.0-SNAPSHOT |
thbkrkr
added
>bug
|
buildkite test this -f p=kind,t=TestTelemetry,s=8.10.0-SNAPSHOT |
|
buildkite test this -f p=kind,t=TestTelemetry,s=8.10.0-SNAPSHOT |
|
buildkite test this -f p=kind,t=TestTelemetry,s=8.10.0-SNAPSHOT |
rhr323
changed the title
thbkrkr
approved these changes
Sep 6, 2023
| @@ -27,15 +28,32 @@ func MakeTelemetryRequest(kbBuilder Builder, k *test.K8sClient) (StackStats, err | |||
| if err != nil { | |||
| return StackStats{}, err | |||
| } | |||
|
|
|||
| // a few extra headers a required by Kibana for this internal API | |||
There was a problem hiding this comment.
Suggested change
| // a few extra headers a required by Kibana for this internal API | |
| // a few extra headers are required by Kibana for this internal API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Telemetry test suite.
Since 8.10, the telemetry API URLs have changed: elastic/kibana#159839
Old URL:
/api/telemetry/%s/clusters/_statsNew URL:
/internal/telemetry/clusters/_statsThere's a simple branching which this PR adds that will generate the appropriate URL based on the stack version. For the new API a few extra headers are also added to the HTTP request.