Remove stack image defintion feature and fix image overrides #6997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
added
>test
|
buildkite test this -f p=gke,E2E_STACK_VERSION=8.9.0-SNAPSHOT,t=TestVersionUpgradeTwoNodesToLatest8x |
|
buildkite test this -f p=gke,s=8.9.0-SNAPSHOT,t=TestVersionUpgradeTwoNodesToLatest8x |
|
I spotted a small bug in the way we detect if we build cloud-on-k8s/.buildkite/scripts/common/trigger.sh Lines 60 to 62 in e3fa2fa cloud-on-k8s/.buildkite/scripts/common/operator-image.sh Lines 54 to 55 in e3fa2fa |
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Jul 10, 2023
…#6997) Remove the unused stack versions feature from the e2e code. Reset the image when setting the version so that stateful builder code won't keep an image digest for a version previously set (see current test failures) // pseudo code newBuilder { .setVersion("8.9.0-SNPSHOT") } // version: "8.9.0-SNAPSHOT" // image: docker.elastic.co/elasticsearch/elasticsearch@sha256:39599c71bd7446fc3c38f22462ba5c86ce65813c4ec38eb3b71bb876061351d4 b.setVersion("8.8.0") // version: "8.8.0" // image: docker.elastic.co/elasticsearch/elasticsearch@sha256:39599c71bd7446fc3c38f22462ba5c86ce65813c4ec38eb3b71bb876061351d4 // test is not actually running 8.8.0 at this point but still 8.9.0-SNAPSHOT Co-authored-by: Thibault Richard <[email protected]> (cherry picked from commit 67a4086) # Conflicts: # docs/reference/dependencies.asciidoc # go.mod
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pebrc
added a commit
that referenced
this pull request
Jul 10, 2023
…6999) Remove the unused stack versions feature from the e2e code. Reset the image when setting the version so that stateful builder code won't keep an image digest for a version previously set (see current test failures) // pseudo code newBuilder { .setVersion("8.9.0-SNPSHOT") } // version: "8.9.0-SNAPSHOT" // image: docker.elastic.co/elasticsearch/elasticsearch@sha256:39599c71bd7446fc3c38f22462ba5c86ce65813c4ec38eb3b71bb876061351d4 b.setVersion("8.8.0") // version: "8.8.0" // image: docker.elastic.co/elasticsearch/elasticsearch@sha256:39599c71bd7446fc3c38f22462ba5c86ce65813c4ec38eb3b71bb876061351d4 // test is not actually running 8.8.0 at this point but still 8.9.0-SNAPSHOT Co-authored-by: Thibault Richard <[email protected]> (cherry picked from commit 67a4086) # Conflicts: # docs/reference/dependencies.asciidoc # go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused stack versions feature from the e2e code.
Reset the image when setting the version so that stateful builder code won't keep an image digest for a version previously set (see current test failures)