Only configure Stack Monitoring if association reconciled #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test this please |
pebrc
reviewed
Feb 14, 2022
pebrc
approved these changes
Feb 14, 2022
This was referenced Mar 28, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Currently, if a referenced monitoring Elasticsearch does not exist, Stack Monitoring is still configured with empty values in beat configs causing the beats to enter in state `CrashLoopBackOff`. This happens only for ES-ES. For KB-ES, the call to `AllowVersion()` checks that `assoc.AssociationConf() != nil`, so the reconciliation is aborted if the association is not yet configured. This commits fixes both for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a referenced monitoring Elasticsearch does not exist, Stack Monitoring is still configured with empty values in beat configs causing the beats to
CrashLoopBackOff.This happens only for ES-ES. For KB-ES, the call to
AllowVersion()checks thatassoc.AssociationConf() != nil, so the reconciliation is aborted if the association is not yet configured. I fixed both for consistency.