Adjust Agent startup command to Ubuntu base image #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
reviewed
Jan 17, 2022
pkg/controller/agent/pod.go
Outdated
| func trustCAScript(version version.Version, caPath string) string { | ||
| sharedCAPath := "/etc/pki/ca-trust/source/anchors/" | ||
| updateCmd := "update-ca-trust" | ||
| if version.Major == 8 { |
There was a problem hiding this comment.
Do we want >= 8? Otherwise, we'd have to update this again when work began on v9.
There was a problem hiding this comment.
Well, I guess it's a question of whether we think that the next version is going to go back to CentOS style path/cmd, as that's how it will currently be handled.
There was a problem hiding this comment.
No, this is a good observation. Even if there is not other major after 8 we should not box ourselves in here.
naemono
approved these changes
Jan 18, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
The base image for Elastic Agent changes from CentOS to Ubuntu in 8.0.0. This adjusts the script that updates the certificates in the image to trust the Elasticsearch certificates the operator generates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5250
As stated in the title this adjusts the CA trust script we are running on startup when Agent is associated with an Elasticsearch instance to the new Ubuntu base image Agent is using in 8.x