Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack-monitoring.asciidoc #5022

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

kunisen
Copy link
Contributor

@kunisen kunisen commented Nov 8, 2021

Per the PR below, add the minimum version to manual.

#4528

enable stack logging for the ES container using the environment variable ES_LOG_STYLE=file
Minimum supported Stack version is 7.14.0 (to benefit from ES_LOG_STYLE=file)

image

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • If you submit code, is your pull request against master? We recommend pull requests against master. We will backport them as needed. => Not a code but a doc PR

Per the PR below, add the minimum version to manual.

#4528
> enable stack logging for the ES container using the environment variable ES_LOG_STYLE=file
> Minimum supported Stack version is 7.14.0 (to benefit from ES_LOG_STYLE=file)
@botelastic botelastic bot added the triage label Nov 8, 2021
@thbkrkr thbkrkr added the >docs Documentation label Nov 8, 2021
@botelastic botelastic bot removed the triage label Nov 8, 2021
@thbkrkr thbkrkr requested a review from alaudazzi November 8, 2021 11:08
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pebrc pebrc merged commit d0272e1 into 1.8 Nov 9, 2021
@pebrc
Copy link
Collaborator

pebrc commented Nov 9, 2021

I just realised that this should have targeted master and be back ported to 1.8. and 1.9 if necessary. 😞

@thbkrkr thbkrkr added the v1.8.0 label Nov 15, 2021
@thbkrkr thbkrkr deleted the kunisen-patch-eck-update-stack-monitoring-doc-1 branch November 24, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v1.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants