Avoid updating the association status when no association #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
commented
Oct 21, 2021
pebrc
approved these changes
Oct 21, 2021
No, I will add one. |
pebrc
reviewed
Oct 21, 2021
…reconciliation-when-no-association
Co-authored-by: Peter Brachwitz <[email protected]>
pebrc
approved these changes
Oct 21, 2021
thbkrkr
added a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Oct 21, 2021
This fixes a bug where the association status of the Elasticsearch resource is updated by the EsMonitoring association controller when there is no association and therefore no changes to be made. The `oldStatus` and the `newStatus` appeared to be different because one was nil and the other was empty. The equality tests now supports this situation.
thbkrkr
added a commit
that referenced
this pull request
Oct 25, 2021
) This fixes a bug where the association status of the Elasticsearch resource is updated by the EsMonitoring association controller when there is no association and therefore no changes to be made. The `oldStatus` and the `newStatus` appeared to be different because one was nil and the other was empty. The equality tests now supports this situation.
thbkrkr
deleted the
skip-association-reconciliation-when-no-association
branch
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
This fixes a bug where the association status of the Elasticsearch resource is updated by the EsMonitoring association controller when there is no association and therefore no changes to be made. The `oldStatus` and the `newStatus` appeared to be different because one was nil and the other was empty. The equality tests now supports this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4985.