Annotate APM Server Pods with co.elastic.logs/module #3840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
jenkins test this please |
barkbay
reviewed
Oct 15, 2020
pkg/controller/apmserver/pod.go
Outdated
|
|
||
| // DefaultAnnotations are the default annotations for the apmserver pods | ||
| DefaultAnnotations = map[string]string{ | ||
| annotation.FilebeatModuleAnnotation: "apmserver", |
There was a problem hiding this comment.
I left a message on #3721 because I'm not sure that this module is available yet, see elastic/beats#15054
Annotate APM Server pods with `co.elastic.logs/module: apmserver` annotation to give a hint to filebeat so that it uses the appropriate module to analyze the logs of the container. Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
3271-annotation
branch
from
8bb87b3 to
156eb58
Compare
|
I'm closing this one because I don't think a filebeat module for the APM Server is available yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate APM Server pods with
co.elastic.logs/module: apm-serverannotation to give a hint to filebeat so that it uses theappropriate module to analyze the logs of the container.
fixes: #3721
Signed-off-by: prateekpandey14 [email protected]