Update linter #2725
Merged
Update linter #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyasabo
added
the
:ci
.golangci.yml
Outdated
| @@ -19,6 +19,7 @@ linters: | |||
| - scopelint | |||
| - whitespace # added in 1.19 | |||
| - wsl # added in 1.20 | |||
| - gomnd # added in 1.23 | |||
There was a problem hiding this comment.
Nit: it would be nice to maintain the sorted order in this list
.golangci.yml
Outdated
| - linters: | ||
| - stylecheck | ||
| text: 'ST1016: methods on the same type should have the same receiver name.*"in".*' | ||
| - path: cmd/manager/main\.go |
There was a problem hiding this comment.
Again, this list was roughly sorted by path. No big deal though.
There was a problem hiding this comment.
Ah I didn't realize for either of them, fixing
|
jenkins test this please |
|
I actually changed this to the next to latest version of golangci-lint because it is OOMing jenkins. Already open issue here: And example test run failure of previous version of this PR with 1.24.0: |
|
jenkins test this please |
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug when troubleshooting the linter failure in #2724 that is resolved in newer golangci-lint versions (a lot of discussion in golangci/golangci-lint#827).
Fixes a bunch of linter warnings: