Inherit existing sset.volumeClaimTemplates ownerReferences #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update the Elasticsearch CRD to a new version, existing ownerReferences in StatefulSets.volumeClaimTemplates still point to the "old" Elasticsearch apiVersion (eg. `v1beta1` instead of `v1`). Since the volumeClaimtemplate section is immutable, the ownerRef apiVersion cannot be updated so the StatefulSet update is rejected. In that situation, it is fine to just keep the existing ownerRef targeting the deprecated Elasticsearch apiVersion. It does not prevent resource garbage collection to happen as expected. This commit also changes the way we recently set a Namespace to the claim, to not error out in `SetControllerReference`. We don't need that namespace (and it breaks backward compatibility), so we now just set it temporarily for `SetControllerReference` to not return any error.
Merged
sebgl
commented
Dec 5, 2019
| claim.Namespace = es.Namespace | ||
| if err := reconciler.SetControllerReference(&es, &claim, scheme); err != nil { | ||
| return nil, err | ||
| } | ||
| claim.Namespace = "" |
There was a problem hiding this comment.
This deals with bdf1e1f in a backward-compatible way.
There was a problem hiding this comment.
Thanks for including the explanation. Since we're using our own version for now it would have taken me a bit to understand
anyasabo
reviewed
Dec 5, 2019
anyasabo
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2192.
When we update the Elasticsearch CRD to a new version, existing
ownerReferences in StatefulSets.volumeClaimTemplates still point to the
"old" Elasticsearch apiVersion (eg.
v1beta1instead ofv1).Since the volumeClaimtemplate section is immutable, the ownerRef
apiVersion cannot be updated so the StatefulSet update is rejected.
In that situation, it is fine to just keep the existing ownerRef
targeting the deprecated Elasticsearch apiVersion. It does not prevent
resource garbage collection to happen as expected.
This commit also changes the way we recently set a Namespace to the
claim, to not error out in
SetControllerReference. We don't need thatnamespace (and it breaks backward compatibility), so we now just set it
temporarily for
SetControllerReferenceto not return any error.