Use a bugfixed version of controllerutil.SetControllerReference #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily duplicate the fixed version of `controllerutil.SetControllerReference` in our own code, until we get a proper release of controller-runtime with the fix. At which point we can safely remove this file and rely on `controllerutil.SetControllerReference` again. controller-runtime PR including the fix: kubernetes-sigs/controller-runtime#707
The latest version of `controllerutil.SetControllerReference` does a safety check on owner vs. object namespace mismatches. We technically don't need to include a namespace in the VolumeClaimtemplates of a StatefulSet, but since we know in which namespace the PVC will be created anyway, it's safe to include the namespace so we pass the function safety check.
|
Follow-up issue so we don't forget to remove the temporary code duplication: #2212 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2191.
Goal
Temporarily duplicate the fixed version of
controllerutil.SetControllerReferencein our own code, until we get aproper release of controller-runtime with the fix.
At which point we can safely remove this file and rely on
controllerutil.SetControllerReferenceagain.controller-runtime PR including the fix:
kubernetes-sigs/controller-runtime#707
Tweaks
The latest version of
controllerutil.SetControllerReferencedoes asafety check on owner vs. object namespace mismatches.
We technically don't need to include a namespace in the
VolumeClaimtemplates of a StatefulSet, but since we know in which
namespace the PVC will be created anyway, it's safe to include the
namespace so we pass the function safety check.