Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in TestKibanaEsSample #1756

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fix panic in TestKibanaEsSample #1756

merged 2 commits into from
Sep 19, 2019

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Sep 19, 2019

Fix the following e2e test:

12:02:11  === RUN   TestKibanaEsSample/Add_some_data_to_the_cluster_before_starting_the_mutation
12:02:11  panic: runtime error: invalid memory address or nil pointer dereference [recovered]
12:02:11      panic: runtime error: invalid memory address or nil pointer dereference
12:02:11  [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1075a2c]
12:02:11  
12:02:11  goroutine 4839 [running]:
12:02:11  testing.tRunner.func1(0xc000778500)
12:02:11      /usr/local/go/src/testing/testing.go:792 +0x387
12:02:11  panic(0x11a6740, 0x1f3a760)
12:02:11      /usr/local/go/src/runtime/panic.go:513 +0x1b9
12:02:11  github.com/elastic/cloud-on-k8s/test/e2e/test/elasticsearch.MustNumDataNodes(0xc000722a00, 0xd, 0xc0007111d0, 0x25, 0xc0008b55e0, 0x19, 0x0, 0x0, 0xc0003fe3a0, 0x11, ...)

pebrc
pebrc approved these changes Sep 19, 2019
View reviewed changes
test/e2e/test/elasticsearch/settings.go Outdated Show resolved Hide resolved
sebgl
sebgl approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barkbay barkbay merged commit b629b0d into elastic:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgl sebgl sebgl approved these changes

@pebrc pebrc pebrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barkbay @pebrc @sebgl