Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move operators dir #1616

Merged
merged 8 commits into from
Aug 23, 2019
Merged

Move operators dir #1616

merged 8 commits into from
Aug 23, 2019

Conversation

anyasabo
Copy link
Contributor

@anyasabo anyasabo commented Aug 22, 2019

Move everything in the operators dir up a level

In general this was

  • rewrite all imports
  • search for any other operators strings and update those
  • Merge READMEs because we had one in each dir. Looks like my markdown plugin also auto-updated the TOC since we had some headers that weren't in the TOC.

Unfortunately sometimes the diffs got so large that it didn't see it as a rename any longer and sees it as a new file, for instance with the Makefiles. For those it might be helpful to view it commit by commit so you can see one is just the mv and then another is fixing it up.

Incomplete

I don't totally understand build/ci/Makefile, e.g.

	@ docker run --rm -t \
...
    	$(CI_IMAGE) \
    	bash -c "make -C operators ci-release"

I think those need to be changed to just make ci-release but I'm not sure, need to do some more reading. Update I went ahead and just did this

@anyasabo anyasabo changed the title (WIP) Move operators dir Move operators dir Aug 22, 2019
@anyasabo
Copy link
Contributor Author

Feel free to merge this if yall approve before I get in tomorrow since I imagine it will make your lives easier to have it in sooner than later

@pebrc pebrc merged commit 571a78a into elastic:master Aug 23, 2019
@anyasabo anyasabo mentioned this pull request Aug 26, 2019
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants