-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI jobs and CI makefile #1610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-kow
added
:ci
Things related to Continuous Integration, automation and releases
>test
Related to unit/integration/e2e tests
>refactoring
labels
Aug 21, 2019
sebgl
reviewed
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a very nice step forward 👍
Left a few suggestions and comments to be discussed.
david-kow
force-pushed
the
ci_setup_improvement
branch
from
August 23, 2019 14:45
25ac0a1
to
beb18f1
Compare
sebgl
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sebgl
approved these changes
Aug 26, 2019
artemnikitin
requested changes
Aug 27, 2019
david-kow
force-pushed
the
ci_setup_improvement
branch
from
August 27, 2019 19:39
50f09a0
to
d0a8b6d
Compare
artemnikitin
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:ci
Things related to Continuous Integration, automation and releases
>refactoring
>test
Related to unit/integration/e2e tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposal from #1528 I've written up last week. In short, this PR:
Description of the CI setup is documented in README.md in this PR.