Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI jobs and CI makefile #1610

Merged
merged 14 commits into from
Aug 28, 2019

Conversation

david-kow
Copy link
Contributor

This implements the proposal from #1528 I've written up last week. In short, this PR:

  • moves config passing from being env var based to file based,
  • moves logic away from ci makefile,
  • makes ci makefile to be runnable from dev box.

Description of the CI setup is documented in README.md in this PR.

@david-kow david-kow added :ci Things related to Continuous Integration, automation and releases >test Related to unit/integration/e2e tests >refactoring labels Aug 21, 2019
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a very nice step forward 👍
Left a few suggestions and comments to be discussed.

build/ci/README.md Show resolved Hide resolved
build/ci/README.md Outdated Show resolved Hide resolved
build/ci/Makefile Outdated Show resolved Hide resolved
operators/Makefile Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
build/ci/Makefile Show resolved Hide resolved
build/ci/e2e/GKE_k8s_versions.jenkinsfile Outdated Show resolved Hide resolved
@david-kow david-kow force-pushed the ci_setup_improvement branch from 25ac0a1 to beb18f1 Compare August 23, 2019 14:45
@david-kow david-kow requested a review from sebgl August 23, 2019 15:07
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@david-kow david-kow force-pushed the ci_setup_improvement branch from 50f09a0 to d0a8b6d Compare August 27, 2019 19:39
@david-kow david-kow requested a review from artemnikitin August 27, 2019 20:23
@david-kow david-kow merged commit c816905 into elastic:master Aug 28, 2019
@david-kow david-kow deleted the ci_setup_improvement branch August 28, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci Things related to Continuous Integration, automation and releases >refactoring >test Related to unit/integration/e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants