Add docker event metricset
#9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2019 23:44
This metricset will retrieve events coming from the Docker events
API [0].
Example output:
```
"docker": {
"event": {
"id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c",
"from": "busybox",
"type": "container",
"action": "die",
"actor": {
"id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c",
"attributes": {
"image": "busybox",
"name": "distracted_lichterman",
"exitCode": "0"
}
},
"time": "2019-01-02T22:41:02.000Z",
"status": "die"
}
}
```
Actor attributes will container labels in the case of container
events, the module will perform dedotting (if enabled) on them.
[0] https://docs.docker.com/engine/api/v1.37/#operation/SystemEvents
exekias
added
enhancement
review
Metricbeat
andrewkroh
reviewed
Jan 3, 2019
| func (m *MetricSet) reportEvent(reporter mb.PushReporterV2, event events.Message) { | ||
| time := time.Unix(event.Time, 0) | ||
|
|
||
| attributes := common.MapStr{} |
There was a problem hiding this comment.
You could allocate a map based on len(event.Actor.Attributes).
jsoriano
reviewed
Jan 3, 2019
jsoriano
approved these changes
Jan 3, 2019
exekias
added
needs_backport
ruflin
reviewed
Jan 7, 2019
| migration: true | ||
| description: > | ||
| The type of object emitting the event | ||
| - name: action |
There was a problem hiding this comment.
You set migration: true here. Is this an alias we only want to be enabled if migration is enabled or have it always? Same for the other aliases.
There was a problem hiding this comment.
I want it to stay, I'm guessing I should not have put migration there 😇 ? I can open a PR to remove them 👍
There was a problem hiding this comment.
yes, otherwise they will disappear.
There was a problem hiding this comment.
@exekias BTW this is a more general discussion if we want to have fields in ECS only or also the "original" name around.
This was referenced Jan 8, 2019
exekias
removed
the
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Jan 18, 2019
* Add docker `event` metricset
This metricset will retrieve events coming from the Docker events
API [0].
Example output:
```
"docker": {
"event": {
"id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c",
"from": "busybox",
"type": "container",
"action": "die",
"actor": {
"id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c",
"attributes": {
"image": "busybox",
"name": "distracted_lichterman",
"exitCode": "0"
}
},
"time": "2019-01-02T22:41:02.000Z",
"status": "die"
}
}
```
Actor attributes will container labels in the case of container
events, the module will perform dedotting (if enabled) on them.
[0] https://docs.docker.com/engine/api/v1.37/#operation/SystemEvents
* Add tests
* Update changelog
* Add missing header
* Add missing file
* Adapt to ECS
* Use a cheaper event for tests
* Close docker client on module shutdown
* Update data
* clean created container
* fix image pull
(cherry picked from commit eef102d)
exekias
added a commit
that referenced
this pull request
Jan 22, 2019
* Add docker `event` metricset (#9856) * Add docker `event` metricset This metricset will retrieve events coming from the Docker events API [0]. Example output: ``` "docker": { "event": { "id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c", "from": "busybox", "type": "container", "action": "die", "actor": { "id": "8c229155b039c2adcb4fab1f987f35a0d1f913dfaa95f3113ed6e4f91eb5398c", "attributes": { "image": "busybox", "name": "distracted_lichterman", "exitCode": "0" } }, "time": "2019-01-02T22:41:02.000Z", "status": "die" } } ``` Actor attributes will container labels in the case of container events, the module will perform dedotting (if enabled) on them. [0] https://docs.docker.com/engine/api/v1.37/#operation/SystemEvents * Add tests * Update changelog * Add missing header * Add missing file * Adapt to ECS * Use a cheaper event for tests * Close docker client on module shutdown * Update data * clean created container * fix image pull (cherry picked from commit eef102d) * Disable migration in docker event fields (#9947) * Move back docker event fields to it's namespace (#10073) * Move back docker event fields to it's namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metricset will retrieve events coming from the Docker events
API [0].
Example output:
Actor attributes will contain labels in the case of container
events, the module will perform dedotting (if enabled) on them.
[0] https://docs.docker.com/engine/api/v1.37/#operation/SystemEvents
closes #6799