Allow users to convert timezone in elasticsearch module filesets #9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
in progress
|
Pinging @elastic/stack-monitoring |
2 tasks
|
I think this needs a |
|
CI failures are related. Looking into them now. |
|
jenkins, test this |
|
@ruflin CI is green now, if you want to review the PR. |
ruflin
approved these changes
Dec 28, 2018
| "input.type": "log", | ||
| "log.offset": 0, | ||
| "message": "[2018-06-19T05:16:15,549] [rest] [authentication_failed] origin_address=[147.107.128.77], principal=[i030648], uri=[/_xpack/security/_authenticate]", | ||
| "@timestamp": "2018-06-19T05:16:15.549Z", |
There was a problem hiding this comment.
I'm surprised by the end line space diff as this file is auto generated there should not be a difference. Did you touch this file manually perhaps?
There was a problem hiding this comment.
I did manually touch it, to update the @timestamp values in each expected document.
There was a problem hiding this comment.
Sure, I can regenerate them. It was a small change that I could make it global search replace so I didn't bother, but I'll regenerate them now.
There was a problem hiding this comment.
Regenerated in d9a2bac.
ruflin
approved these changes
Dec 28, 2018
CHANGELOG.asciidoc
Outdated
| @@ -202,6 +202,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...v7.0.0-alpha2[Check the | |||
| - Rename many `icinga.*` fields to map to ECS. {pull}9294[9294] | |||
| - Rename many `postgresql.log.*` fields to map to ECS. {pull}9303[9303] | |||
| - Rename many `kafka.log.*` fields to map to ECS. {pull}9297[9297] | |||
| - Add `convert_timezone` option to Elasticsearch module to convert dates to UTC. {issue}9756[9756] {pull}9761[9761] | |||
There was a problem hiding this comment.
I think this changelog is in the wrong place as alpha2 is already shipped. Best directly add it to .next changelog.
There was a problem hiding this comment.
Moved in d9f5f1f.
ruflin
approved these changes
Dec 28, 2018
|
jenkins, test this |
2 tasks
Merged
4 tasks
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Jan 8, 2019
…earch module filesets (#9830) Cherry-pick of PR #9761 to 6.x branch. Original message: This PR updates the following filesets in the `elasticsearch` Filebeat module to accept a `var.convert_timezone` configuration setting: * [x] server * [x] audit * [x] slowlog * [x] deprecation The `gc` fileset was not modified because Elasticsearch GC logs already emit timestamps with timezone information in them. Fixes partially #9756. Related: #9797.
ycombinator
added
review
v6.6.1
needs_backport
Merged
4 tasks
ycombinator
added
v6.6.0
and removed
needs_backport
2 tasks
ycombinator
added a commit
that referenced
this pull request
Jan 30, 2019
…earch module filesets (#10403) * Allow users to convert timezone in elasticsearch module filesets (#9761) This PR updates the following filesets in the `elasticsearch` Filebeat module to accept a `var.convert_timezone` configuration setting: * [x] server * [x] audit * [x] slowlog * [x] deprecation The `gc` fileset was not modified because Elasticsearch GC logs already emit timestamps with timezone information in them. Fixes partially #9756. Related: #9797. (cherry picked from commit 3559e58) * Regenerating generated files * Fixing duplicated header in CHANGELOG * Updating generated file
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ogstash module filesets (elastic#10407) Cherry-pick of PR elastic#9797 to 6.6 branch. Original message: This PR updates the following filesets in the `logstash` Filebeat module to accept a `var.convert_timezone` configuration setting: * [x] log * [x] slowlog Fixes partially elastic#9756. Related: elastic#9761
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lasticsearch module filesets (elastic#10403) * Allow users to convert timezone in elasticsearch module filesets (elastic#9761) This PR updates the following filesets in the `elasticsearch` Filebeat module to accept a `var.convert_timezone` configuration setting: * [x] server * [x] audit * [x] slowlog * [x] deprecation The `gc` fileset was not modified because Elasticsearch GC logs already emit timestamps with timezone information in them. Fixes partially elastic#9756. Related: elastic#9797. (cherry picked from commit 43d976e) * Regenerating generated files * Fixing duplicated header in CHANGELOG * Updating generated file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following filesets in the
elasticsearchFilebeat module to accept avar.convert_timezoneconfiguration setting:The
gcfileset was not modified because Elasticsearch GC logs already emit timestamps with timezone information in them.Fixes partially #9756. Related: #9797.