Be more strict when handling the access token #9624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validations for the Kibana response with the access token, and enforce that the access token is not empty when unpacking the configuration. Since the access token in the keystore could be edited. Fixes: elastic#9621
houndci-bot
reviewed
Dec 18, 2018
ph
added
review
needs_backport
urso
reviewed
Dec 18, 2018
urso
reviewed
Dec 18, 2018
x-pack/libbeat/management/config.go
Outdated
| @@ -66,6 +67,8 @@ const ManagedConfigTemplate = ` | |||
| #xpack.monitoring.elasticsearch: | |||
| ` | |||
|
|
|||
| var errEmptyAccessToken = errors.New("access_token is empty, you must reenroll your beats") | |||
|
updated with the changes. |
urso
approved these changes
Dec 18, 2018
kaiyan-sheng
approved these changes
Dec 18, 2018
ph
added a commit
to ph/beats
that referenced
this pull request
Dec 18, 2018
Add validations for the Kibana response with the access token, and enforce that the access token is not empty when unpacking the configuration. Since the access token in the keystore could be edited. Fixes: elastic#9621 (cherry picked from commit 8dd740f)
ph
added
v6.6.0
and removed
needs_backport
ph
added a commit
to ph/beats
that referenced
this pull request
Dec 24, 2018
Add validations for the Kibana response with the access token, and enforce that the access token is not empty when unpacking the configuration. Since the access token in the keystore could be edited. Fixes: elastic#9621 (cherry picked from commit 8dd740f)
ph
added a commit
to ph/beats
that referenced
this pull request
Dec 24, 2018
Add validations for the Kibana response with the access token, and enforce that the access token is not empty when unpacking the configuration. Since the access token in the keystore could be edited. Fixes: elastic#9621 (cherry picked from commit 8dd740f)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ess token (elastic#9790) Cherry-pick of PR elastic#9624 to 6.5 branch. Original message: Add validations for the Kibana response with the access token, and enforce that the access token is not empty when unpacking the configuration. Since the access token in the keystore could be edited. Fixes: elastic#9621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.
Fixes: #9621