Cherry-pick #8851 to 6.x: Keep a mapping of autodiscover instances and deployed configs #9290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#8851) * Keep a mapping of autodiscover instances and deployed configs This changes stop behavior, sometimes not all metadata is available in the stop event, this results in some configs not being stopped because of that. After this change, we only rely on instance id from the event to decide what configs to delete, as we'll keep a map of instance id -> deployed configs. (cherry picked from commit 571b008)
jsoriano
approved these changes
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8851 to 6.x branch. Original message:
This changes stop behavior, sometimes not all metadata is available in
the stop event, this results in some configs not being stopped because
of that.
After this change, we only rely on instance id from the event to decide
what configs to delete, as we'll keep a map of instance id -> deployed
configs.
Fixes #8535