-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for ILM feature #9263
Add docs for ILM feature #9263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions. After reading that I feel like I know how to use ILM so I think they are good.
@andrewkroh Thanks for the early review. Will also need to fix some urls. |
Assigned @dedemorton on this PR as she will take it over. |
I still need to rebase, but the content here is ready for a review. I've moved the info to its own topic. It needs more work, but would like to get it merged before/around the time 6.6 hits the fan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Overall LGTM.
I added the |
I've rebased and cleaned up some of the cross reference text to be consistent with how other writers are handling cross references. I think this is ready to merge. I still need to update the security docs, but I'll do that in a separate PR. @ruflin What's required wrt privileges? #9470 suggests: { "cluster": ["manage_index_templates","monitor"], If this is correct, I'll update the security docs next week. Thanks! |
@bmorelli25 If you want to pick up the ILM docs for 6.6, you'll need to grab this after it's merged and add an entry to the topic that pulls in the config topics. I'm assuming ILM will work for APM indices, no? Sorry this is landing so late. |
@dede I don't think ILM support is coming to APM until after 7.0, but I'll need to double check. |
@dedemorton LGTM. Can't approve as it's my own PR. Feel free to merge. For the privileges: Can you check with @jakelandis to confirm this? |
* Add docs for ILM feature This is a follow up for elastic#7963 * Add edits * Minor fixes * Add changes from the review * Make cross references consistent * Fix rebase error
* Add docs for ILM feature This is a follow up for elastic#7963 * Add edits * Minor fixes * Add changes from the review * Make cross references consistent * Fix rebase error
* Add docs for ILM feature This is a follow up for elastic#7963 * Add edits * Minor fixes * Add changes from the review * Make cross references consistent * Fix rebase error
* Add docs for ILM feature This is a follow up for elastic#7963 * Add edits * Minor fixes * Add changes from the review * Make cross references consistent * Fix rebase error
* Add docs for ILM feature This is a follow up for elastic#7963 * Add edits * Minor fixes * Add changes from the review * Make cross references consistent * Fix rebase error
This is a follow up for #7963