Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for ILM feature #9263

Merged
merged 6 commits into from
Jan 22, 2019
Merged

Add docs for ILM feature #9263

merged 6 commits into from
Jan 22, 2019

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Nov 28, 2018

This is a follow up for #7963

@ruflin ruflin added docs in progress Pull request is currently in progress. libbeat labels Nov 28, 2018
@ruflin ruflin mentioned this pull request Nov 28, 2018
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions. After reading that I feel like I know how to use ILM so I think they are good.

libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/outputconfig.asciidoc Outdated Show resolved Hide resolved
@ruflin
Copy link
Contributor Author

ruflin commented Nov 29, 2018

@andrewkroh Thanks for the early review. Will also need to fix some urls.

@ruflin
Copy link
Contributor Author

ruflin commented Dec 14, 2018

Assigned @dedemorton on this PR as she will take it over.

@ruflin ruflin requested review from a team as code owners January 17, 2019 22:19
@dedemorton
Copy link
Contributor

I still need to rebase, but the content here is ready for a review. I've moved the info to its own topic. It needs more work, but would like to get it merged before/around the time 6.6 hits the fan.

Copy link
Contributor Author

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Overall LGTM.

libbeat/docs/shared-ilm.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/shared-ilm.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/shared-ilm.asciidoc Outdated Show resolved Hide resolved
libbeat/docs/shared-ilm.asciidoc Outdated Show resolved Hide resolved
@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Jan 18, 2019
@ruflin
Copy link
Contributor Author

ruflin commented Jan 18, 2019

I added the needs_backport label as this will have to go into 6.6 and 6.x too.

@dedemorton
Copy link
Contributor

I've rebased and cleaned up some of the cross reference text to be consistent with how other writers are handling cross references. I think this is ready to merge.

I still need to update the security docs, but I'll do that in a separate PR.

@ruflin What's required wrt privileges? #9470 suggests:

{ "cluster": ["manage_index_templates","monitor"],
"indices": [ { "names": [ "beat-" ], "privileges": ["write","delete","create_index"] } ] }

If this is correct, I'll update the security docs next week. Thanks!

@dedemorton
Copy link
Contributor

@bmorelli25 If you want to pick up the ILM docs for 6.6, you'll need to grab this after it's merged and add an entry to the topic that pulls in the config topics. I'm assuming ILM will work for APM indices, no? Sorry this is landing so late.

@bmorelli25
Copy link
Member

bmorelli25 commented Jan 18, 2019

@dede I don't think ILM support is coming to APM until after 7.0, but I'll need to double check.

@ruflin
Copy link
Contributor Author

ruflin commented Jan 21, 2019

@dedemorton LGTM. Can't approve as it's my own PR. Feel free to merge.

For the privileges: Can you check with @jakelandis to confirm this?

@dedemorton dedemorton merged commit 2bd4f50 into elastic:master Jan 22, 2019
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 22, 2019
* Add docs for ILM feature

This is a follow up for elastic#7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jan 22, 2019
* Add docs for ILM feature

This is a follow up for elastic#7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
dedemorton added a commit that referenced this pull request Jan 23, 2019
* Add docs for ILM feature

This is a follow up for #7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
dedemorton added a commit that referenced this pull request Jan 23, 2019
* Add docs for ILM feature

This is a follow up for #7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
@dedemorton dedemorton removed in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. labels Jan 29, 2019
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
* Add docs for ILM feature

This is a follow up for elastic#7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
* Add docs for ILM feature

This is a follow up for elastic#7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Add docs for ILM feature

This is a follow up for elastic#7963

* Add edits

* Minor fixes

* Add changes from the review

* Make cross references consistent

* Fix rebase error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants