Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky tests seen in #9194 #9217

Merged
merged 2 commits into from
Nov 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions filebeat/tests/system/test_crawler.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import codecs
import os
import time
import unittest
from nose.plugins.skip import Skip, SkipTest
import shutil

Expand Down Expand Up @@ -263,6 +264,7 @@ def test_file_disappear(self):

assert len(output) == 5 + 6

@unittest.skipIf(os.name == 'nt', 'flaky test https://github.com/elastic/beats/issues/9213')
def test_file_disappear_appear(self):
"""
Checks that filebeat keeps running in case a log files is deleted
Expand Down
2 changes: 2 additions & 0 deletions filebeat/tests/system/test_harvester.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import codecs
import time
import io
import unittest
from parameterized import parameterized

"""
Expand Down Expand Up @@ -75,6 +76,7 @@ def test_close_renamed(self):
data = self.get_registry()
assert len(data) == 2

@unittest.skipIf(os.name == 'nt', 'flaky test https://github.com/elastic/beats/issues/9214')
def test_close_removed(self):
"""
Checks that a file is closed if removed
Expand Down
1 change: 1 addition & 0 deletions filebeat/tests/system/test_registrar.py
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,7 @@ def test_clean_removed(self):
else:
assert data[0]["offset"] == len("make sure registry is written\n" + "2\n")

@unittest.skipIf(os.name == 'nt', 'flaky test https://github.com/elastic/beats/issues/9215')
def test_clean_removed_with_clean_inactive(self):
"""
Checks that files which were removed, the state is removed
Expand Down
3 changes: 3 additions & 0 deletions libbeat/tests/system/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import os
import shutil
import subprocess
import sys
import unittest


class Test(BaseTest):
Expand Down Expand Up @@ -177,6 +179,7 @@ def test_logging_metrics(self):
lambda: self.log_contains("Total non-zero metrics"),
max_timeout=2)

@unittest.skipIf(sys.platform == 'darwin', 'flaky test https://github.com/elastic/beats/issues/9216')
def test_persistent_uuid(self):
self.render_config_template()

Expand Down