Cherry-pick #9068 to 6.x: Add tests for etcd 3.3 on metricbeat module #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7c1e6b6)
exekias
approved these changes
Nov 15, 2018
| @@ -78,6 +78,7 @@ https://github.com/elastic/beats/compare/v6.5.0...6.x[Check the HEAD diff] | |||
| *Metricbeat* | |||
|
|
|||
| - Collect custom cluster `display_name` in `elasticsearch/cluster_stats` metricset. {pull}8445[8445] | |||
| - Test etcd module with etcd 3.3. {pull}9068[9068] | |||
There was a problem hiding this comment.
I think we don't add entries for tests, as these doesn't make it into the product itself
There was a problem hiding this comment.
In this case I wanted to mention it as indication of coverage for this version, as changed in the docs too.
There was a problem hiding this comment.
But I'm ok with changing or removing it in a future PR as this is already in master, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9068 to 6.x branch. Original message: