Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for json.is_array setting #8951

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Add documentation for json.is_array setting #8951

merged 1 commit into from
Nov 7, 2018

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Nov 6, 2018

Motivated by https://discuss.elastic.co/t/how-to-query-json-url-with-http-module/155572 and follow up doc PR to #6480.

This PR documents the json.is_array setting supported by the http/json metricset. The setting was introduced in #6480 but not documented at the time.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator merged commit 5b5bb23 into elastic:master Nov 7, 2018
@ycombinator ycombinator deleted the docs-metricbeat-json-array branch November 7, 2018 19:33
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Nov 7, 2018
ycombinator added a commit that referenced this pull request Nov 12, 2018
…#8974)

Cherry-pick of PR #8951 to 6.x branch. Original message: 

Motivated by https://discuss.elastic.co/t/how-to-query-json-url-with-http-module/155572 and follow up doc PR to #6480.

This PR documents the `json.is_array` setting supported by the `http/json` metricset. The setting was introduced in #6480 but not documented at the time.
ycombinator added a commit that referenced this pull request Nov 13, 2018
Fixing typo introduced in 5b5bb23 (#8951).

Typo was [noticed in the backport PR for #8951](#8974 (comment)) so need to backport this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants