Lengthen default test timeout to 15 seconds #8896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On busy CI servers, I suspect some flakiness, as in the case of elastic#8667 (review) is due to the server being temporarily too busy. Let's try lengthening this time to see if that helps.
andrewvc
added
flaky-test
ruflin
approved these changes
Nov 1, 2018
|
Well, we saw the same telemetry test fail here, lol, so that's not it. I'll take another look tomorrow. |
andrewvc
added
the
Team:obs-ds-hosted-services
|
I would suggest to close this PR for now. If we see a test taking too long, we should manually increaes the timeout of this specific test instead of generally increasing it. What I worry if we increase it for all tests is that in case of many failures the tests would take 50% longer to completely fail. |
|
Closing per the recommendation |
andrewvc
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On busy CI servers, I suspect some flakiness, as in the case of #8667 (review) is due to the server being temporarily too busy.
Let's try lengthening this time to see if that helps.