-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM MQ Metricbeat module #8870
IBM MQ Metricbeat module #8870
Conversation
The module is now able to collect the MQ metrics. 1.) In the module each metricseat is collected in parallel. This is not possible with the MQ lib at the moment. @ruflin Is there a way to collect the metricsets sequentially without putting everything in one fetch metricset? 2.) To build metricbeat with ibmmq module it needs to have the MQ C library available locally under for Linux
for Windows
This needs to be switched to dynamic linking in mqi.go 3.) The PubSub metricset needs to be added 4.) The imports are pointing to my repo. This needs to be switched when it will be merged into Elastic repo |
That all metricset fetches are made in parallel is by design. To run it sequentially it would require quite fundamental changes. I would definitively recommend that each metricset maintains it's own connection, so if one metricset is blocked it does not impact others. Are there some advantages to this? |
Some notes on my end for this PR:
|
Here is the docker image that can be used for testing: https://hub.docker.com/r/ibmcom/mq/ |
You need to create it with a Queue Manager Name This Queue Manager Name needs to be in the configuration. cc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some comments for whoever follows up with the fixes to not forget about things.
@@ -0,0 +1,746 @@ | |||
package ibmmqlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be pulled in as vendor directory to make the separation clear.
[float] | ||
=== Compability | ||
|
||
This module is tested with IBM MQ v... TODO . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the TODO in the docs
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
df3e0d3
to
f762840
Compare
Signed-off-by: chrismark <[email protected]>
f762840
to
c05dbd1
Compare
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
I believe we can close this PR in favor of a simple light module implementation. |
This is the metricbeat module for IBM MQ. Which will be the transformation of this standalone beat
@ruflin is helping to integrate this as this is the first x-pack module for metricbeat