[WIP] Beta AWS ELB Autodiscovery Provider #8680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
enhancement
in progress
andrewvc
force-pushed
the
aws-autodiscover
branch
from
da8b68d to
5cd5d0d
Compare
andrewvc
commented
Oct 31, 2018
| @@ -11,16 +11,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
Temporary changes while I work on this feature.
andrewvc
changed the title
This was referenced Nov 9, 2018
|
@andrewvc On my todo list but didn't get to it yet. Could you rebase? Note: Pretty sure it's missing a Changelog entry. |
andrewvc
added
the
Team:obs-ds-hosted-services
|
I think we're pausing work here. I'm going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for AWS ELBs. It is currently blocked on #8851 . As a result it currently does not work because it needs the ability to uniquely identify configs based on UUIDs (in the case of AWS these are ARNs).
What I'm looking for here is an initial code review. I do know it works because I temporarily hacked together a poor version of #8851 and tested it against a real API. I've since reverted that.
This should be initially released as a beta feature. The tests contained here are unit tests only. Full release would require integration tests. I think that would add too much scope to this PR however. Orchestrating resource creation / destruction tends to be a good amount of effort, and I would prefer to move on to the EC2 autodiscovery provider before then. I should also mention that the EC2 discovery mechanism in Elasticsearch doesn't have any integration tests AFAIK, and has been quite solid.