Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionbeat to the build process #8639

Merged
merged 3 commits into from
Oct 19, 2018
Merged

Add functionbeat to the build process #8639

merged 3 commits into from
Oct 19, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Oct 17, 2018 •
edited
Loading

This add beatless/functionbeat to the build processes and do the
following changes:

  • Use a custom packages.yml to only build some of the artifact.
  • Each distribution also include a linux binary to be run on AWS lambda
  • Some refactoring is done in the mage.go file to allow to specify a
    specs file more easily.
  • Make sure that beatless is added to build/distributions/beatless
  • Make sure we run on the latest templates.

Notes

Depends on #8485, interesting commit is e08029a

@ph ph added the review label Oct 17, 2018
@kvch
Copy link
Contributor

kvch commented Oct 18, 2018

Are you going to rename beatless in the build process in a follow-up PR?

@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

@kvch yes in a follow-up PR once the big one is merged.

@ph ph assigned tsg and unassigned andrewkroh Oct 18, 2018
@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

I will fix the make check 😢

@ph ph force-pushed the fix/beatless-packages branch from e08029a to f226be3 Compare October 18, 2018 12:49
@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

@tsg rebase + make check fixed, this make it a simple self contains commit to be applied to the feature branch.

@ph ph force-pushed the feature-beatless branch from 96677a3 to a1c2729 Compare October 18, 2018 13:06
@ph ph force-pushed the fix/beatless-packages branch 3 times, most recently from f5e2105 to 5d8e79d Compare October 18, 2018 14:17
@ph
This add beatless/functionbeat to the build processes and do the
250f36c 
following changes:

    Use a custom packages.yml to only build some of the artifact.
    Each distribution also include a linux binary to be run on AWS lambda
    Some refactoring is done in the mage.go file to allow to specify a
    specs file more easily.
    Make sure that beatless is added to build/distributions/beatless
@ph ph force-pushed the fix/beatless-packages branch from 5d8e79d to 250f36c Compare October 18, 2018 15:11
@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

I think there is a small problems with make check, I've looked at the license and it should be correct.

@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

Found the issue, using make update at the root generate a fields.go with the wrong header but header is fine when you generate it inside the beatless directory.

@ph
Copy link
Contributor Author

ph commented Oct 18, 2018

Fix the docs build issue.

@ph ph mentioned this pull request Oct 18, 2018
Closed
42 tasks
@urso
Copy link

urso commented Oct 18, 2018

Can you print a listing of the final artifacts, so we can check they are complete?

tsg
tsg approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick testing and seems fine, and the packaging commit looks sane. I think this is good.

@tsg
Copy link
Contributor

tsg commented Oct 18, 2018

@urso:

$ ls -l
total 274336
-rw-r--r--  1 tsg  staff  25191214 Oct 18 14:01 beatless-7.0.0-darwin-x86_64.tar.gz
-rw-r--r--  1 tsg  staff       165 Oct 18 14:01 beatless-7.0.0-darwin-x86_64.tar.gz.sha512
-rw-r--r--  1 tsg  staff  29069407 Oct 18 14:01 beatless-7.0.0-linux-x86.tar.gz
-rw-r--r--  1 tsg  staff       161 Oct 18 14:01 beatless-7.0.0-linux-x86.tar.gz.sha512
-rw-r--r--  1 tsg  staff  29517926 Oct 18 14:01 beatless-7.0.0-linux-x86_64.tar.gz
-rw-r--r--  1 tsg  staff       164 Oct 18 14:01 beatless-7.0.0-linux-x86_64.tar.gz.sha512
-rw-r--r--  1 tsg  staff  27305535 Oct 18 14:01 beatless-7.0.0-windows-x86.zip
-rw-r--r--  1 tsg  staff       160 Oct 18 14:01 beatless-7.0.0-windows-x86.zip.sha512
-rw-r--r--  1 tsg  staff  27704174 Oct 18 14:01 beatless-7.0.0-windows-x86_64.zip
-rw-r--r--  1 tsg  staff       163 Oct 18 14:01 beatless-7.0.0-windows-x86_64.zip.sha512

Then the macOs one for example:

$ tree
.
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── beatless
├── beatless.reference.yml
├── beatless.yml
├── fields.yml
├── kibana
│   ├── 5
│   │   └── index-pattern
│   │       └── beatless.json
│   └── 6
│       └── index-pattern
│           └── beatless.json
└── pkg
    └── beatless

6 directories, 10 files

@ph
Copy link
Contributor Author

ph commented Oct 19, 2018

I will merge this

@ph ph merged commit 521433c into elastic:feature-beatless Oct 19, 2018
ph added a commit that referenced this pull request Oct 24, 2018
@ph
Add functionbeat to the build process (#8639)
657b3a7 
* This add beatless/functionbeat to the build processes and do the
following changes:

    Use a custom packages.yml to only build some of the artifact.
    Each distribution also include a linux binary to be run on AWS lambda
    Some refactoring is done in the mage.go file to allow to specify a
    specs file more easily.
    Make sure that beatless is added to build/distributions/beatless

* fix the issue with license on the fields.go

* Adding minimal docs to satisfy DTD requirements and not fail the build
ph added a commit that referenced this pull request Oct 24, 2018
@ph
Add functionbeat to the build process (#8639)
bfcb7f1 
* This add beatless/functionbeat to the build processes and do the
following changes:

    Use a custom packages.yml to only build some of the artifact.
    Each distribution also include a linux binary to be run on AWS lambda
    Some refactoring is done in the mage.go file to allow to specify a
    specs file more easily.
    Make sure that beatless is added to build/distributions/beatless

* fix the issue with license on the fields.go

* Adding minimal docs to satisfy DTD requirements and not fail the build
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ph
Add functionbeat to the build process (elastic#8639)
1a0682f 
* This add beatless/functionbeat to the build processes and do the
following changes:

    Use a custom packages.yml to only build some of the artifact.
    Each distribution also include a linux binary to be run on AWS lambda
    Some refactoring is done in the mage.go file to allow to specify a
    specs file more easily.
    Make sure that beatless is added to build/distributions/beatless

* fix the issue with license on the fields.go

* Adding minimal docs to satisfy DTD requirements and not fail the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@tsg tsg tsg approved these changes

Assignees

@urso urso

@tsg tsg

Labels
Functionbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ph @kvch @urso @tsg @houndci-bot @andrewkroh