Filebeat: Fast filecheck #8627
Closed
Filebeat: Fast filecheck #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Oct 16, 2018
filebeat/input/log/log_test.go
Outdated
| buf := make([]byte, 10) | ||
|
|
||
| i := 0 | ||
| var receivedError error = nil |
There was a problem hiding this comment.
should drop = nil from declaration of var receivedError; it is the zero value
filebeat/input/log/log_test.go
Outdated
| buf := make([]byte, 10) | ||
|
|
||
| i := 0 | ||
| var receivedError error = nil |
There was a problem hiding this comment.
should drop = nil from declaration of var receivedError; it is the zero value
filebeat/input/log/log.go
Outdated
| @@ -51,16 +52,30 @@ func NewLog( | |||
| } | |||
| } | |||
|
|
|||
| var checkTicker *time.Ticker = nil | |||
There was a problem hiding this comment.
should drop = nil from declaration of var checkTicker; it is the zero value
houndci-bot
reviewed
Oct 16, 2018
| @@ -1,4 +1,4 @@ | |||
| // Licensed to Elasticsearch B.V. under one or more contributor | |||
| receivedError// Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
expected 'package', found 'IDENT' receivedError (and 1 more errors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5556
check_status_intervalto control the file status checking interval.