Cherry-pick #8415 to 6.x: Heartbeat autodiscover #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Oct 13, 2018
CHANGELOG.asciidoc
Outdated
| @@ -19,6 +19,8 @@ https://github.com/elastic/beats/compare/v6.4.0...6.x[Check the HEAD diff] | |||
|
|
|||
| *Heartbeat* | |||
|
|
|||
| - Added autodiscovery support {pull}8415[8415] | |||
There was a problem hiding this comment.
Why is this a breaking change?
ruflin
reviewed
Oct 13, 2018
|
Ah yeah, accidentally put it in the wrong section
…On Sat, Oct 13, 2018, 5:29 AM Nicolas Ruflin ***@***.***> wrote:
***@***.**** commented on this pull request.
Overall LGTM expect changelog.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8593 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIBY3Cra-enXHWI60qxfn5lO2NFbn2Vks5ukbJ1gaJpZM4XKwQK>
.
|
andrewvc
force-pushed
the
backport_8415_6.x
branch
from
764e945 to
e403677
Compare
|
@ruflin updated the changelog entry and re-pushed. |
Autodiscover support for Heartbeat + tests (cherry picked from commit cff3e40)
andrewvc
force-pushed
the
backport_8415_6.x
branch
from
e403677 to
7522b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8415 to 6.x branch. Original message:
This is a complete PR for heartbeat automatic reload.