Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request 773 (adding username to topbeat) #845

Merged
merged 9 commits into from
Jan 26, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Jan 25, 2016

This is merging #773 and in addition updating the vendored gosigar.

@andrewkroh
Copy link
Member

LGTM. We should really add a system test case for Username. That can go into a separate PR.

@tsg tsg removed the review label Jan 26, 2016
@tsg
Copy link
Contributor Author

tsg commented Jan 26, 2016

@andrewkroh Good point. I think it's easy enough for me to add it in this one, so we're sure we don't forget about it.

@andrewkroh
Copy link
Member

I implemented a test case for this and opened a PR to this branch. tsg#1

Add Topbeat system test for process username
@tsg
Copy link
Contributor Author

tsg commented Jan 26, 2016

Sub-PR merged :)

andrewkroh added a commit that referenced this pull request Jan 26, 2016
Merge pull request 773 (adding username to topbeat)
@andrewkroh andrewkroh merged commit 8b5ab89 into elastic:master Jan 26, 2016
@biswajit86
Copy link

Could you please update the field_name that is exposed by this change in the [list of topbeat fields ].(https://github.com/elastic/beats/blob/master/topbeat/docs/fields.asciidoc).

Is it username or Username

@andrewkroh
Copy link
Member

It's proc.username. I will be updating fields.asciidoc for this shortly.

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Mar 30, 2016
Backport of  elastic#1128 to 1.2 - Change Cpu.Get() on Windows to not use floating point arithmetic
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Apr 6, 2016
@tsg tsg deleted the merge_773 branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants