Cherry-pick #8192 to 6.x: Get rid of errors generated by xpack code for elasticsearch/shard metricset
#8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Sep 11, 2018
…etricset (#8192) * Refactoring: Extract passthruFields function for broader use * Passthru fields that could sometimes by null * Do not report errors in xpack path as they will go into metricbeat index * Un-hardcode index name * More fixes * Regenerating data.json * Fixing order * Renaming data JSON file to include version * Renaming data.700.json back to data.json * Adding unit test fixture for 7.0.0
|
Only CI failure is this unrelated flaky test: #8208. So I'm merging this PR now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8192 to 6.x branch. Original message:
I was testing the
elasticsearch/shardmetricset withxpack.enabled: trueonmasterand ran into a few errors:Investigating a bit I found that:
nodeandrelocating_nodecan sometimes be returned asnullin theGET _cluster/state/version,master_node,nodes,routing_tableElasticsearch API response used by this metricset, andnumberfield has been renamed in the Elasticserach API response toshardnow. I can't find when it wasnumberbut it is definitelyshardnow.This PR updates the code to get rid of these errors.
It also un-hardcodes the name of the monitoring index set in
data_xpack.go.Testing this PR
Enable the
elasticsearchmetricset:Edit
modules.d/elasticsearch.ymland setmetricsets: [ "shard" ]andxpack.enabled: true.Run metricbeat:
Check in Elasticsearch that you don't have any documents in
metricbeat-*for theelasticsearchmodule (since we are usingxpack.enabled: true).Check in Elasticsearch that you have documents in
.monitoring-es-6-mb-*withtype:shard