Force input to file in filebeat module tests #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can be modules that support multiple inputs, currently we only support module tests with file input so modules whose default input is a different one fails. This change assumes that a `var.input` setting is used to select the input, and sets it to file on tests.
|
We currently don't have modules using other inputs, but there is one in progress that uses syslog by default (#8014), this is problematic with the test_modules test as it is prepared to work only with files. |
|
I agree. As in module tests we only care if Filebeat can read configuration of a module and ES can process correctly the input, file input is sufficient. Reading from network can add unnecessary complexity in this case. We have separate E2E tests for testing inputs of Filebeat. |
jsoriano
added
the
needs_backport
kvch
approved these changes
Aug 30, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2018
There can be modules that support multiple inputs, currently we only support module tests with file input so modules whose default input is a different one fails. This change assumes that a `var.input` setting is used to select the input, and sets it to file on tests. (cherry picked from commit 30ac8e8)
jsoriano
added
v6.5.0
and removed
needs_backport
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2018
There can be modules that support multiple inputs, currently we only support module tests with file input so modules whose default input is a different one fails. This change assumes that a `var.input` setting is used to select the input, and sets it to file on tests. (cherry picked from commit 30ac8e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be modules that support multiple inputs, currently we only
support module tests with file input so modules whose default input is a
different one fails. This change assumes that a
var.inputsetting isused to select the input, and sets it to file on tests.