Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky clean_removed test #8092

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Aug 27, 2018

This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes #7690

This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes elastic#7690
@ruflin ruflin added Filebeat Filebeat :Testing flaky-test Unstable or unreliable test cases. review needs_backport PR is waiting to be backported to other branches. labels Aug 27, 2018
@jsoriano jsoriano merged commit e346293 into elastic:master Aug 28, 2018
@ruflin ruflin deleted the fix-clean_removed-test branch August 28, 2018 11:43
ruflin added a commit to ruflin/beats that referenced this pull request Aug 28, 2018
This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes elastic#7690

(cherry picked from commit e346293)
@ruflin ruflin added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 28, 2018
ruflin added a commit to ruflin/beats that referenced this pull request Aug 28, 2018
This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes elastic#7690

(cherry picked from commit e346293)
@ruflin ruflin added the v6.4.1 label Aug 28, 2018
exekias pushed a commit that referenced this pull request Aug 28, 2018
This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes #7690

(cherry picked from commit e346293)
exekias pushed a commit that referenced this pull request Aug 28, 2018
This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes #7690

(cherry picked from commit e346293)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
This is a potential fix for the flaky clean_removed test. The problem in the test seems to be that sometimes not all states are cleaned up yet. This is changing it by waiting for all pending cleanups to happen.

Closes elastic#7690

(cherry picked from commit 6625835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat flaky-test Unstable or unreliable test cases. review :Testing v6.4.1 v6.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Test test_registrar.test_clean_removed fails
2 participants