Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique event log for Winlogbeat system tests #8006

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

andrewkroh
Copy link
Member

This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes #7902

This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes elastic#7902
@andrewkroh andrewkroh added bug Winlogbeat flaky-test Unstable or unreliable test cases. review and removed bug labels Aug 17, 2018
@ruflin ruflin merged commit 4da32c4 into elastic:master Aug 20, 2018
@ruflin
Copy link
Collaborator

ruflin commented Aug 20, 2018

Should we backport this to 6.x?

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 21, 2018
This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes elastic#7902

(cherry picked from commit 4da32c4)
@andrewkroh
Copy link
Member Author

Yes. Backport open in #8038.

ruflin pushed a commit that referenced this pull request Aug 22, 2018
This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes #7902

(cherry picked from commit 4da32c4)
@andrewkroh andrewkroh deleted the bugfix/wlb/test-isolation branch November 8, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. review v6.5.0 Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Winlogbeat] Flaky test_fields_not_under_root test
2 participants