Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about append_fields #7903

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Conversation

dedemorton
Copy link
Contributor

Closes #7040.

Question: Should setup.template.json.enabled be marked as experimental in the reference.yml? It is marked as experimental in the reference docs.

Changes:

  • Edited existing reference docs. I thought there was a lot of detail buried in the note, so I moved it into a paragraph. (Lots of readers skip over notes.)
  • Added append_fields to the reference.yml and marked it as experimental.

@dedemorton dedemorton added docs review needs_backport PR is waiting to be backported to other branches. labels Aug 8, 2018
@dedemorton dedemorton requested a review from ruflin August 8, 2018 00:27
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. I would remove the experimental flag from the docs for the json template loading. It's here to stay and we also don't have any logs in the code.

@ruflin ruflin merged commit 9621b23 into elastic:master Aug 9, 2018
dedemorton added a commit to dedemorton/beats that referenced this pull request Aug 17, 2018
* Add docs about append_fields
* Remove experimental tag from setup.template.json.enabled description
jsoriano pushed a commit that referenced this pull request Aug 17, 2018
…#7996)

* Add document for beat export dashboard (#7696)
* Add safeguard related statements for max_backoff setting (#7889)
* Add docs about append_fields (#7903)
* Fix processor autodiscovery docs for Filebeat (#7937)
* Minor fixes to attributes in module docs (#7949)
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Aug 18, 2018
dedemorton added a commit to dedemorton/beats that referenced this pull request Aug 30, 2018
* Add docs about append_fields
* Remove experimental tag from setup.template.json.enabled description
dedemorton added a commit to dedemorton/beats that referenced this pull request Aug 31, 2018
* Add docs about append_fields
* Remove experimental tag from setup.template.json.enabled description
dedemorton added a commit that referenced this pull request Sep 4, 2018
…7937 #7939 #7948 #7949 #7950)  (#8188)

* Reset modulename attribute at the end of a file (#7888)

* Add safeguard related statements for max_backoff setting (#7889)

* Add docs about append_fields (#7903)

* Add docs about append_fields
* Remove experimental tag from setup.template.json.enabled description

* Metricbeat: Add compatibility notes where missing (#7939)

* Metricbeat: Add compatibility notes where missing, based on integration tests

* Added review suggestions

* Add missing config options to Logstash section of reference.yml (#7883)

Closes #3062

* Fix processor autodiscovery docs for Filebeat (#7937)

{ needs escaping as otherwise asciidoc will show an empty code block.

* Add document for beat export dashboard (#7696)

* Add document for beat export dashboard

Follow up from #7239

* move to command reference

* address review comments

* review comments applied

* apply review feedback

* Replace golang with Go (#7948)

I've been told that using "golang" instead of "Go" is considered a faux pas in some circles. :-)

I've replaced instances in the external docs, but I did not update the changelog, readmes, or code files.

* Minor fixes to attributes in module docs (#7949)

* Add recommendation to avoid harvesting symlinks when dealing with file rotation (#7950)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…tic#7903 elastic#7937 elastic#7949) (elastic#7996)

* Add document for beat export dashboard (elastic#7696)
* Add safeguard related statements for max_backoff setting (elastic#7889)
* Add docs about append_fields (elastic#7903)
* Fix processor autodiscovery docs for Filebeat (elastic#7937)
* Minor fixes to attributes in module docs (elastic#7949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants