Fixes to metricbeat's KVM module #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
added
bug
review
Metricbeat
adriansr
changed the title
adriansr
added
review
and removed
in progress
adriansr
force-pushed
the
fix/mb/7792
branch
2 times, most recently
from
bd91665 to
e0fbb1f
Compare
jsoriano
approved these changes
Jul 30, 2018
CHANGELOG.asciidoc
Outdated
| @@ -21,6 +21,8 @@ https://github.com/elastic/beats/compare/v6.4.0...master[Check the HEAD diff] | |||
|
|
|||
| *Metricbeat* | |||
|
|
|||
| - Fixed a panic when the kvm module cannot establish a connection to libvirtd. {issue}7792[7792]. | |||
andrewkroh
reviewed
Jul 30, 2018
| @@ -2,7 +2,10 @@ | |||
| metricsets: ["dommemstat"] | |||
| enabled: true | |||
| period: 10s | |||
| hosts: ["localhost"] | |||
| hosts: ["unix:///var/run/libvirt/libvirt-sock"] | |||
| # for remote hosts, setup network access in libvirtd.conf | |||
| hosts: ["localhost"] | ||
| hosts: ["unix:///var/run/libvirt/libvirt-sock"] | ||
| # for remote hosts, setup network access in libvirtd.conf | ||
| # and use the tcp schema: |
| } | ||
|
|
||
| if len(gotDomainMemoryStats) == 0 { | ||
| report.Error(errors.New("no domain memory stats found")) | ||
| report.Error(fmt.Errorf("no memory stats for domain %s", d.Name)) |
There was a problem hiding this comment.
Personally I'd prefer errors.Errorf over fmt.Errorf in case we decide to consume the available stack information that it adds to the error.
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes elastic#7792
The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts.
|
Test failure doesn't seem related. |
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Oct 23, 2018
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes elastic#7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. (cherry picked from commit 76d3949)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Oct 23, 2018
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes elastic#7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. (cherry picked from commit 76d3949)
jsoriano
added a commit
that referenced
this pull request
Oct 24, 2018
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes #7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. Co-authored-by: Adrian Serrano <[email protected]> (cherry picked from commit 76d3949)
jsoriano
added a commit
that referenced
this pull request
Oct 24, 2018
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes #7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. Co-authored-by: Adrian Serrano <[email protected]> (cherry picked from commit 76d3949)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Improper error handling caused a panic when connection to libvirtd couldn't be stablished. Cleaned up error handling a little bit. Fixes elastic#7792 The default settings for the kvm module didn't work. Updated to connect to the unix socket by default, and provide a hint on how to setup access to libvirtd running on remote hosts. Co-authored-by: Adrian Serrano <[email protected]> (cherry picked from commit 6de03f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to the kvm module:
host: [ "localhost" ]results in the module trying to create a network connection without schema. It will always fail with"dial: Unknown network ".For a default installation of
libvirtd, the only possible method is to use:host: [ "unix:///var/run/libvirt/libvirt-sock" ].Also some gidance is provided for setting up remote monitoring.