Refactor beat exit #771
Merged
Refactor beat exit #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyrilleverrier have a look |
|
LGTM |
| var exit int | ||
|
|
||
| func (b *Beat) Signal() { | ||
| b.error = fmt.Errorf("Beat stop through signal") |
There was a problem hiding this comment.
@andrewkroh @urso this is called when the beat exists through CTRL-C. What should the exit code be in your opinion? 1 or 0?
There was a problem hiding this comment.
since we use the kill signal to shutdown our beats, I'd assume it to be 0.
There was a problem hiding this comment.
Ok, will remove the error again in this case.
There was a problem hiding this comment.
I would expect 0 on a clean shutdown triggered by signal.
* Introduce Signal function which is called if using CTRL-C or similar * Run now returns an error and doesn't exist itself anymore * Fix spooler and crawler shutdown issue * Update mockbeat to check Run return error. Thanks to @cyrilleverrier for his contribution here.
| err := beat.Run(Name, "", winlogbeat.New()) | ||
| if err != nil { | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
This should be done in all Beats, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @cyrilleverrier for his contribution here.