Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gopsutil to 2.18.06 #7483

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Update gopsutil to 2.18.06 #7483

merged 1 commit into from
Jul 2, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 1, 2018

No description provided.

@jsoriano jsoriano added the review label Jul 1, 2018
@jsoriano jsoriano requested a review from andrewkroh July 1, 2018 19:56
@jsoriano jsoriano mentioned this pull request Jul 1, 2018
Closed
@jsoriano jsoriano force-pushed the gopsutil-2.18.06 branch from 529c317 to 32fad60 Compare July 1, 2018 20:05
@jsoriano jsoriano force-pushed the gopsutil-2.18.06 branch from 32fad60 to 252e4c2 Compare July 1, 2018 20:10
@jsoriano
Copy link
Member Author

jsoriano commented Jul 1, 2018

jenkins, test this again please

@ruflin ruflin merged commit af1638c into elastic:master Jul 2, 2018
@jsoriano
Copy link
Member Author

jsoriano commented Jul 2, 2018

@ruflin @andrewkroh I have just seen that I overlooked the use of HOST_* environment variables, I have opened a new PR to fix this shirou/gopsutil#544.
In any case it wouldn't be a regression because previous implementation with udevadmn wouldn't also make use of these environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ruflin