Minor: Small fixes for add_kubernetes_metadata #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ph
commented
Jun 28, 2018
•
ph
commented
- Empty predicates are protected by the mutex.
- When we fail to build an indexer or matcher we log the warning but we don't add them to the execution.
ph
changed the title
ph
force-pushed
the
fix/small-fixes-add-metadata-kubernetes
branch
from
c47f1bc to
453a561
Compare
exekias
reviewed
Jun 28, 2018
CHANGELOG.asciidoc
Outdated
| @@ -73,6 +73,7 @@ https://github.com/elastic/beats/compare/v6.2.3...master[Check the HEAD diff] | |||
| - Allow index-pattern only setup when setup.dashboards.only_index=true. {pull}7285[7285] | |||
| - Fix duplicating dynamic_fields in template when overwriting the template. {pull}7352[7352] | |||
| - Fix a panic on the Dissect processor when we have data remaining after the last delimiter. {pull}7449[7449] | |||
| - When we fail to build a Kubernetes' indexer or matcher we produce a warning but we don't them to the execution. {pull}7466[7466] | |||
There was a problem hiding this comment.
typo: we don't add? them to the execution
exekias
approved these changes
Jun 28, 2018
|
@exekias fixed typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.